Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_designs): Remove vxlan_vlan_aware_bundles in favor of evpn_vlan_aware_bundles #2865

Merged
merged 4 commits into from
May 19, 2023
Merged

Refactor(eos_designs): Remove vxlan_vlan_aware_bundles in favor of evpn_vlan_aware_bundles #2865

merged 4 commits into from
May 19, 2023

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented May 19, 2023 •
edited
Loading

Change Summary

Related Issue(s)

Fixes #2834

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested a review from a team as a code owner May 19, 2023 09:45
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 19, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team May 19, 2023 10:38
@Shivani-chourasiya Shivani-chourasiya force-pushed the vxlan_aware_bundles_to_evpn_aware_bundles branch from 02ee80a to a11c518 Compare May 19, 2023 10:48
@carlbuchmann carlbuchmann mentioned this pull request May 19, 2023
Closed
18 tasks
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label May 19, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-rc1 milestone May 19, 2023
carlbuchmann
carlbuchmann approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit c9362d4 into aristanetworks:devel May 19, 2023
32 checks passed
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees
No one assigned
Labels
rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v4.0.0-rc1
Development

Successfully merging this pull request may close these issues.

Add schemas for missing keys in eos_designs
4 participants
@Shivani-chourasiya @carlbuchmann @ClausHolbechArista @Shivani-gslab