Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_cli_config_gen): Deprecate old keys under gNMI #2876

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Deprecate old keys under gNMI

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • deprecate keys "enable_vrfs" and "octa" in favor of new data models previously inplemented.
  • Update docs to be consistent in writing gnmi with mixed case: "gNMI"
  • Update molecule scenarios

How to test

  • Updated existing molecule scenario using the deprecated keys to instead use the new keys. No config change (except reordering)

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 22, 2023 09:11
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 22, 2023
@ClausHolbechArista ClausHolbechArista changed the title Doc(eos cli config gen): Deprecate old keys under gNMI Doc(eos_cli_config_gen): Deprecate old keys under gNMI May 22, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-rc2 milestone May 22, 2023
@pvinci-arista
Copy link
Contributor

Do we need to create/update a porting-guide-5.x.x, or can it be caught from the schema data alone?

@ClausHolbechArista
Copy link
Contributor Author

Do we need to create/update a porting-guide-5.x.x, or can it be caught from the schema data alone?

These deprecations will not affect the result of existing projects, but are just warnings about future removals. So I don't think they have to go into the porting guide.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit c7eff56 into aristanetworks:devel May 26, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Doc(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants