Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Ensure unique VRF names in schemas #2878

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Ensure unique VRF names in schemas

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

A few schemas did not enforce unique VRF names by leveraging primary_key in the schema.
This affects the ability to properly merge custom_structured_configuration from eos_designs.

How to test

No changes to anything, since we should already be configuring this correctly.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 22, 2023 13:40
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels May 22, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-rc2 milestone May 22, 2023
@ClausHolbechArista ClausHolbechArista added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label May 24, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 881ff80 into aristanetworks:devel May 26, 2023
34 checks passed
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Jul 13, 2023
gmuloc pushed a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants