Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update Dual DC L3LS example #2904

Merged

Conversation

xaviramon
Copy link
Contributor

@xaviramon xaviramon commented May 29, 2023

Change Summary

Update of Dual DC example

Proposed changes

Update README.md doc and group_vars

How to test

Generate docs and validate REAMDE.md file and we follow best practices for group_vars

@github-actions github-actions bot added the state: conflict PR with conflict label May 30, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label May 30, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@xaviramon xaviramon marked this pull request as ready for review May 30, 2023 15:05
@xaviramon xaviramon requested a review from a team as a code owner May 30, 2023 15:05
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-rc3 milestone May 31, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat: Update Dual DC L3LS example Doc: Update Dual DC L3LS example May 31, 2023
@JulioPDX JulioPDX force-pushed the dual_dc_documentation_4.0rc branch from cb83e7a to 7bf2d65 Compare June 7, 2023 01:51
@ClausHolbechArista ClausHolbechArista modified the milestones: v4.0.0-rc3, v4.0.0 Jun 7, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 209b6ae into aristanetworks:devel Jun 12, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants