Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Ignore "overlay_routing_protocol_address_family: ipv6" on l2leaf #2955

Merged
merged 2 commits into from Jun 5, 2023
Merged

Fix(eos_designs): Ignore "overlay_routing_protocol_address_family: ipv6" on l2leaf #2955

merged 2 commits into from Jun 5, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Fix Ignore overlay_routing_protocol_address_family: ipv6 on l2leaf

Related Issue(s)

Fixes #2954

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Add underlay_router: true condition for rendering overlay facts
  • Add underlay_router: true condition for rendering overlay peering address
  • Add test coverage first recreating the issue and then verifying the fix.

How to test

  • Added molecule coverage and no side effects

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner June 5, 2023 06:39
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Jun 5, 2023
@ClausHolbechArista ClausHolbechArista added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Jun 5, 2023
@carlbuchmann carlbuchmann added this to the v4.0.0-rc3 milestone Jun 5, 2023
carlbuchmann
carlbuchmann approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@carlbuchmann carlbuchmann merged commit db88fd9 into aristanetworks:devel Jun 5, 2023
32 checks passed
@Vibhu-gslab Vibhu-gslab mentioned this pull request Jul 14, 2023
Merged
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Aug 11, 2023
Vibhu-gslab added a commit to Vibhu-gslab/avd that referenced this pull request Aug 11, 2023
@Vibhu-gslab
Fix(eos_designs): Ignore "overlay_routing_protocol_address_family: ip…
ad72712 
…v6" on l2leaf (aristanetworks#2955)
carlbuchmann pushed a commit that referenced this pull request Aug 11, 2023
@Vibhu-gslab @ClausHolbechArista
Fix(eos_designs): Ignore "overlay_routing_protocol_address_family: ip…
7e36d46 
…v6" on l2leaf (#2955) (#3043)

Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v4.0.0-rc3
Development

Successfully merging this pull request may close these issues.

l2leaf affected by rfc5549 evpn settings
2 participants
@ClausHolbechArista @carlbuchmann