Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Incorrect type for ospf.area in network services keys #2998

Merged
merged 8 commits into from Jul 7, 2023
Merged

Fix(eos_designs): Incorrect type for ospf.area in network services keys #2998

merged 8 commits into from Jul 7, 2023

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Jun 21, 2023 •
edited

Change Summary

Incorrect type for ospf.area in network services keys, should be of type string instead of an integer and update default value.

Related Issue(s)

Fixes #2996

Component(s) name

arista.avd.eos_designs

Proposed changes

  • updated schema to type str
  • update schema default from 0 to "0" .
  • updated structured config output from 0 to "0"

How to test

  • Molecule passes and no changes.

@carlbuchmann carlbuchmann requested review from a team as code owners June 21, 2023 17:53
@carlbuchmann carlbuchmann added the type: bug Something isn't working label Jun 21, 2023
@ClausHolbechArista
Copy link
Contributor

we should default to "0.0.0.0" since that is how EOS translates "0"

@carlbuchmann
Copy link
Member Author

carlbuchmann commented Jun 21, 2023 •
edited

we should default to "0.0.0.0" since that is how EOS translates "0"

Agreed and updated PR.

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jun 22, 2023
carlbuchmann and others added 4 commits June 23, 2023 08:14
@carlbuchmann @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_designs/schemas/schem…
2d1faf1 
…a_fragments/defs_network_services.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@carlbuchmann
update schema
d395a0d
@carlbuchmann
revert change to default value
1a34246
@carlbuchmann
update CI
8e69496
@github-actions github-actions bot removed the state: CI Updated CI scenario have been updated in the PR label Jun 23, 2023
@carlbuchmann carlbuchmann mentioned this pull request Jun 23, 2023
Open
@ClausHolbechArista ClausHolbechArista requested a review from a team July 3, 2023 06:31
@gmuloc gmuloc merged commit 6443612 into aristanetworks:devel Jul 7, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronize schema for ospf area type in between eos_designs and eos_cli_config_gen
3 participants
@carlbuchmann @ClausHolbechArista @gmuloc