Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Combine core_interfaces and l3_edge python_modules #3003

Merged

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Jun 23, 2023

Change Summary

Restructure code to combine core_interfaces and l3_edge python_modules

Related Issue(s)

Fixes #68

Component(s) name

arista.avd.eos_designs

Proposed changes

Combining core_interfaces and l3_edge python module into same class to avoid duplicate code.

How to test

Run the molecule eos_designs_unit_tests, there should not be any changes in the structured_configs.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested review from a team as code owners June 23, 2023 07:47
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Jun 23, 2023
@Shivani-chourasiya Shivani-chourasiya changed the title Refactor(eos_designs): Restructure code to combine core_interfaces and l3_edge python_modules Refactor(eos_designs): Combine core_interfaces and l3_edge python_modules Jun 23, 2023
@ClausHolbechArista
Copy link
Contributor

Would be good to update the eos_designs_internal_notes.md file with the new class name.

@ClausHolbechArista ClausHolbechArista requested a review from a team June 23, 2023 11:31
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jun 23, 2023
@Shivani-chourasiya
Copy link
Contributor Author

Would be good to update the eos_designs_internal_notes.md file with the new class name.

Done!

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit b92f950 into aristanetworks:devel Jun 27, 2023
32 checks passed
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants