Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Relax schema for empty prefix-lists #3008

Merged
merged 3 commits into from Jul 6, 2023
Merged

Fix(eos_cli_config_gen): Relax schema for empty prefix-lists #3008

merged 3 commits into from Jul 6, 2023

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Jun 26, 2023 •
edited

Change Summary

Relax schema for empty prefix-lists

Related Issue(s)

Fixes #2596

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested review from a team as code owners June 26, 2023 09:38
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Jun 26, 2023
ClausHolbechArista
ClausHolbechArista reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test of this somewhere, so we see that we can in fact generate config for a prefix-list without any sequence numbers.

@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft July 3, 2023 06:33
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review July 3, 2023 06:38
@ClausHolbechArista ClausHolbechArista marked this pull request as draft July 3, 2023 06:38
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 3, 2023
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review July 3, 2023 07:07
@ClausHolbechArista ClausHolbechArista requested a review from a team July 4, 2023 09:46
carlbuchmann
carlbuchmann approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 70626bb into aristanetworks:devel Jul 6, 2023
38 checks passed
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees
No one assigned
Labels
rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Relax schema for empty prefix-lists
4 participants
@Shivani-chourasiya @carlbuchmann @ClausHolbechArista @Shivani-gslab