Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_designs): Deprecate cvp_instance_ip in favor of cvp_instance_ips #3028

Merged
merged 4 commits into from Aug 4, 2023
Merged

Refactor(eos_designs): Deprecate cvp_instance_ip in favor of cvp_instance_ips #3028

merged 4 commits into from Aug 4, 2023

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Jul 7, 2023 •
edited

Change Summary

Deprecate cvp_instance_ip in favor of cvp_instance_ips

Related Issue(s)

Fixes #2673

Component(s) name

arista.avd.eos_designs

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested review from a team as code owners July 7, 2023 12:17
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 7, 2023
@Shivani-chourasiya Shivani-chourasiya force-pushed the cv_intance_ips branch 4 times, most recently from 4c4443a to 5228a2c Compare July 9, 2023 08:45
@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft July 10, 2023 13:03
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review July 11, 2023 06:42
@Shivani-chourasiya Shivani-chourasiya force-pushed the cv_intance_ips branch 2 times, most recently from 14c4b20 to af91e11 Compare July 11, 2023 06:56
@github-actions github-actions bot removed the state: CI Updated CI scenario have been updated in the PR label Jul 11, 2023
@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft July 11, 2023 07:34
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 25, 2023
@Shivani-chourasiya Shivani-chourasiya force-pushed the cv_intance_ips branch 3 times, most recently from d9fe2fe to 520e8be Compare July 25, 2023 13:10
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review July 25, 2023 13:11
@ClausHolbechArista ClausHolbechArista added this to the v4.3.0-dev1 milestone Jul 31, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team August 3, 2023 09:23
carlbuchmann
carlbuchmann approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 5aaf64b into aristanetworks:devel Aug 4, 2023
33 checks passed
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees
No one assigned
Labels
rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.4.0-dev1
Development

Successfully merging this pull request may close these issues.

Deprecate cvp_instance_ip in favor of cvp_instance_ips
5 participants
@Shivani-chourasiya @gmuloc @carlbuchmann @ClausHolbechArista @Shivani-gslab