Refactor(eos_designs): Using common method for raising duplicate detection error in python_modules #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
…ction error in python_modules
Shivani-chourasiya
force-pushed
the
shared_utils_duplicate
branch
from
f2907f9
to
e095379
Compare
Shivani-chourasiya
force-pushed
the
shared_utils_duplicate
branch
from
e095379
to
8a93c99
Compare
Shivani-chourasiya
changed the title
gmuloc
reviewed
Jul 17, 2023
| list_of_dicts=ethernet_interfaces, | ||
| primary_key="name", | ||
| new_dict=ethernet_interface, | ||
| context="Ethernet Interfaces defined under underlay", |
There was a problem hiding this comment.
There is not really a concept of "under underlay" for a user of AVD so we need to reword this
| f"Duplicate port-channel name {candidate_port_channel_config['name']} with conflicting configurations found while generating port-channels for" | ||
| " connected-endpoints or network-ports" | ||
| ) | ||
| append_if_not_duplicate( |
There was a problem hiding this comment.
do you still need the wrapper function _add_port_channel_if_not_duplicate ? it looks like we could remove it and just call append_if_not_duplicate in the main code?
| list_of_dicts=neighbors, | ||
| primary_key="ip_address", | ||
| new_dict=neighbor, | ||
| context="Ip address defined under BGP neighbor for underlay", |
There was a problem hiding this comment.
Suggested change
| context="Ip address defined under BGP neighbor for underlay", | |
| context="IP address defined under BGP neighbor for underlay", |
Shivani-chourasiya
force-pushed
the
shared_utils_duplicate
branch
2 times, most recently
from
2b5bf51
to
86aa6f6
Compare
Shivani-chourasiya
force-pushed
the
shared_utils_duplicate
branch
2 times, most recently
from
f9723b4
to
fff8bc3
Compare
Shivani-chourasiya
force-pushed
the
shared_utils_duplicate
branch
from
fff8bc3
to
77dfa75
Compare
gmuloc
approved these changes
Jul 18, 2023
ClausHolbechArista
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Using common_method for raising duplicate detection error in python_modules
Related Issue(s)
Fixes #2749
Component(s) name
arista.avd.eos_designsChecklist
User Checklist
Repository Checklist