Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for "include leaked" under BGP redistribution #3071

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add support for "include leaked" under BGP redistribution

Related Issue(s)

Fixes #1385

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

router_bgp:
  redistribute_routes:
    - source_protocol: <str>
      include_leaked: <bool>
  address_family_ipv6:
    redistribute_routes:
      - source_protocol: <str>
        include_leaked: <bool>
  vrfs:
    - name: <str>
      redistribute_routes:
        - source_protocol: <str>
          include_leaked: <bool>

How to test

Added molecule test cases.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners August 1, 2023 08:17
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 1, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos cli_config_gen): Add support for "include leaked" under BGP redistribution Feat(eos_cli_config_gen): Add support for "include leaked" under BGP redistribution Aug 2, 2023
@carlbuchmann carlbuchmann self-requested a review August 4, 2023 12:42
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against custom repo - works great. Schema and docs look good.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit b1b945e into aristanetworks:devel Aug 11, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BGP redistribute connected/static include leaked unsupported
3 participants