Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support inline comments in requirements.txt #3125

Merged
merged 5 commits into from Sep 7, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 7, 2023

Related Issue(s)

Fixes #3122

Component(s) name

plugins

Proposed changes

Added logic to remove inline comments

How to test

Unit test added

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners September 7, 2023 10:35
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit de022e8 into aristanetworks:devel Sep 7, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: verify-requirement does not handle requirements with comments afterwards
3 participants