Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): VTEP override option on node-definitions #3133

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Feat(eos_designs): VTEP override option on node-definitions #3133

merged 6 commits into from
Sep 11, 2023

Conversation

emilarista
Copy link
Contributor

@emilarista emilarista commented Sep 8, 2023 •
edited
Loading

Change Summary

Adds an option to turn on/off VTEP setting on the node-definitions, allowing to override default inherited from node_type_keys toggle.

Component(s) name

arista.avd.eos_designs

Proposed changes

Adds the following knob to node type definitions:

<node-type>:
  ...
  nodes:
    - name: TEST-LEAF
      vtep: true/false

How to test

Tested with molecule.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@emilarista emilarista added this to To Do in DK-PROJECT-02 via automation Sep 8, 2023
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 8, 2023
carlbuchmann
carlbuchmann approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann marked this pull request as ready for review September 9, 2023 01:07
@carlbuchmann carlbuchmann requested review from a team as code owners September 9, 2023 01:07
@ClausHolbechArista ClausHolbechArista merged commit 2e45310 into aristanetworks:devel Sep 11, 2023
34 checks passed
DK-PROJECT-02 automation moved this from To Do to Done Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@emilarista emilarista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
DK-PROJECT-02
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilarista @carlbuchmann @ClausHolbechArista