Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for flow tracking hardware #3199

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Feat(eos_cli_config_gen): Add support for flow tracking hardware #3199

merged 7 commits into from
Oct 13, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 4, 2023 •
edited
Loading

Change Summary

Add support for flow tracking hardware

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Following discussion - introduce new top level flow_tracking - deprecates flow_trackings one as the different types don't have the same keys despite what the cli show command display.

How to test

molecule test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 4, 2023 13:29
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 4, 2023
@gmuloc gmuloc mentioned this pull request Oct 4, 2023
Merged
4 tasks
@gmuloc
Copy link
Contributor Author

gmuloc commented Oct 4, 2023

This PR does not allow to configure flow tracker hardware FOO under ethernet-interfaces. This will be tracked in another issue.

@gmuloc gmuloc mentioned this pull request Oct 4, 2023
Closed
carlbuchmann
carlbuchmann previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - commands being retained may not be something we need to worry about as this may be platform specific support.

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Oct 9, 2023
@gmuloc gmuloc requested review from carlbuchmann and a team October 9, 2023 12:35
@carlbuchmann
+ add flow_tracker.hardware
cc314c2 
- ethernet_interfaces
- port_channel_interfaces
@carlbuchmann carlbuchmann self-requested a review October 12, 2023 19:19
@carlbuchmann carlbuchmann dismissed ClausHolbechArista’s stale review October 12, 2023 19:39

Pushed a couple more changes since your review!

carlbuchmann
carlbuchmann approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit fb51d52 into aristanetworks:devel Oct 13, 2023
39 checks passed
@gmuloc gmuloc removed the role: eos_designs issue related to eos_designs role label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista