Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for BGP link-state address-family #3211

Merged
merged 6 commits into from Oct 10, 2023
Merged

Feat(eos_cli_config_gen): Add support for BGP link-state address-family #3211

merged 6 commits into from Oct 10, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 5, 2023

Change Summary

Adding support for BGP-LS to prepare Path-Selection feature

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

      address_family_link_state:
        bgp:
          missing_policy:
            direction_in_action: <str>
            direction_out_action: <str>
        peer_groups:
          - name: <str>
            activate: <bool>
            missing_policy:
              direction_in_action: <str>
              direction_out_action: <str>
        neighbors:
          - ip_address: <str>
            activate: <bool>
            missing_policy:
              direction_in_action: <str>
              direction_out_action: <str>
        path_selection:
          roles:
            producer: <bool>
            consumer: <bool>
            propagator: <bool>

NOTE FOR REVIEWERS: Please note that in EOS CLI, the role producer not shown, instead the path-selection entry without role ... is implicitly enabling the producer role. Feel free to reach out to me for more details. I have tried to be very explicit in the description

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 5, 2023 15:55
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 5, 2023
@gmuloc gmuloc added EPIC - AVD AutoVPN/WAN and removed role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 5, 2023
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 6, 2023
ClausHolbechArista
ClausHolbechArista approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment on docs. LGTM.

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2 Outdated
{% if router_bgp.address_family_link_state.path_selection.roles is arista.avd.defined %}
{% set path_selection_roles = [] %}
{% if router_bgp.address_family_link_state.path_selection.roles.producer is arista.avd.defined(true) %}
{% do path_selection_roles.append("- producer") %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other docs we just join the raw strings on <br> with no - or *.

@gmuloc gmuloc requested a review from a team October 9, 2023 08:13
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 10, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

emilarista
emilarista approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed, LGTM!

@ClausHolbechArista ClausHolbechArista merged commit b8580a8 into aristanetworks:devel Oct 10, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@emilarista emilarista emilarista approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmuloc @ClausHolbechArista @emilarista