Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Ethernet interfaces ip address dhcp support #3229

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Feat(eos_cli_config_gen): Ethernet interfaces ip address dhcp support #3229

merged 1 commit into from
Oct 12, 2023

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Oct 12, 2023 •
edited
Loading

Change Summary

Add support for dhcp configuration on ethernet interface

interface Ethernet1
   ip address dhcp
   dhcp client accept default-route

Related Issue(s)

Fixes aristanetworks/avd-internal#121

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

ethernet_interfaces:
  - name: Ethernet1
    ip_address: "dhcp"
    dhcp_client_accept_default_route: true

How to test

See molecule test case

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 12, 2023
@carlbuchmann carlbuchmann marked this pull request as ready for review October 12, 2023 01:54
@carlbuchmann carlbuchmann requested review from a team as code owners October 12, 2023 01:54
@ClausHolbechArista ClausHolbechArista requested a review from a team October 12, 2023 06:42
colinmacgiolla
colinmacgiolla approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@colinmacgiolla colinmacgiolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 4b2b619 into aristanetworks:devel Oct 12, 2023
42 checks passed
@gmuloc gmuloc removed the role: eos_designs issue related to eos_designs role label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmacgiolla colinmacgiolla colinmacgiolla approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlbuchmann @colinmacgiolla @ClausHolbechArista @gmuloc