Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add ethernet interface dhcp server config #3231

Merged
merged 1 commit into from Oct 16, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 12, 2023

Change Summary

Adding

interface Ethernet2
  dhcp server ipv4
  dhcp server ipv6

the cli is introduced between bfd and ipv6 enable as per EOS cli:

ceos2(config-if-Et2)#show active
interface Ethernet2
   ip address 1.1.1.1/24
   bfd echo
   dhcp server ipv4
   dhcp server ipv6
   ipv6 enable

Component(s) name

arista.avd.eos_cli_config_gen

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 12, 2023 09:33
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 12, 2023
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get this implemented too for port-channels and SVIs if applicable, but we can take that another day :)

@ClausHolbechArista ClausHolbechArista requested a review from a team October 12, 2023 13:58
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 2d3e078 into aristanetworks:devel Oct 16, 2023
42 checks passed
@pvinci-arista
Copy link
Contributor

There are some caveats. Do we want to add something to the jsonschema description or somewhere else to call them out?

The DHCP Server and DHCP Relay cannot be configured on the same router. The DHCP Relay has a higher precedence so the DHCP Server will be disabled when the DHCP Relay is configured.

If DHCPD is enabled on the router, configuring the EOS DHCP Server may cause DHCPD to crash or have unexpected behaviors.

@gmuloc gmuloc removed the role: eos_designs issue related to eos_designs role label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants