Feat(eos_cli_config_gen): Support of next_hop_unchanged under EVPN address family #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
gmuloc
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Overall LGTM - just one comment regarding adding a new host to molecule only for one line. @ClausHolbechArista is it ok here to put it in router-bgp-evpn even if the config "might be wrong"
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/hosts.ini
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Oct 12, 2023
ClausHolbechArista
added
the
one approval
gmuloc
approved these changes
Oct 18, 2023
gmuloc
removed
the
one approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Permit the explicit configuration of next-hop-unchanged knob under address-family evpn
Related Issue(s)
Fixes #3102
Component(s) name
arista.avd.eos_cli_config_genProposed changes
1/ Modified schema fragment "router_bgp" and template "router-bgp" accordingly
2/ Modified device documentation template accordingly
3/ Added a molecule test (new host "router-bgp-evpn-route-server") as the knob is specific to route server role
How to test
The knob is present under address-family evpn in the generated intended configuration
Checklist
User Checklist
Repository Checklist