Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): change speed group value from int to str #3235

Merged

Conversation

philippebureau
Copy link
Contributor

Change Summary

Change eos_desings platform speed group and eos_cli_config_gen hardware speed group key expected value to string and convert int to str if needed

Related Issue(s)

N/A

Component(s) name

arista.avd.eos_desings
arista.avd.eos_cli_config_gen

Proposed changes

the current implementation expect a integer which does not work for chassis since the value of the speed group use a "/" in the value (ex: 3/5 for linecard 3 group 5)

by inverting the current to expect a string and convert integer to string fixes the issue

How to test

create a speed group in eos_desings or eos_cli_config_gen with string and integer values

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@philippebureau philippebureau requested review from a team as code owners October 12, 2023 17:20
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 12, 2023
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 12, 2023
@philippebureau philippebureau changed the title Fix(eos_designs and eos_cli_config_gen): change speed group value from int to str Fix(eos_designs): change speed group value from int to str Oct 12, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann requested a review from a team October 12, 2023 19:22
Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 2b68cb7 into aristanetworks:devel Oct 13, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants