Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Optimize conversion of structured config outputs #3240

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Optimize conversion of structured config outputs

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Fix several schema type issues hidden by the automatic conversion on the output.
  • Limit conversion to only run for custom structured config.

How to test

No changes to molecule outputs.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista marked this pull request as draft October 13, 2023 12:54
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review October 13, 2023 15:18
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Nov 17, 2023
@carlbuchmann carlbuchmann requested a review from a team November 17, 2023 20:06
@gmuloc gmuloc force-pushed the refactor/eos_designs/Avoid-reliance-on-schema-conversion-for-eos_designs-output branch from f47b306 to be21948 Compare November 21, 2023 10:11
@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 21, 2023
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 914554d into aristanetworks:devel Nov 24, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants