Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(pyavd): Adding "path" attribute to validation_errors and deprecation_warnings. #3255

Merged
merged 3 commits into from Oct 18, 2023
Merged

Feat(pyavd): Adding "path" attribute to validation_errors and deprecation_warnings. #3255

merged 3 commits into from Oct 18, 2023

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Oct 17, 2023 •
edited

Change Summary

Adding "path" attribute to validation_errors and deprecation_warnings.

Proposed changes

  • Added path attribute to AvdValidationError, AvdConversionWarning and AvdDeprecationWarning class.
  • Fixed the path for list elements in deprecation warnings.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab requested review from a team as code owners October 17, 2023 11:10
@Shivani-gslab Shivani-gslab marked this pull request as draft October 17, 2023 13:32
@Shivani-gslab Shivani-gslab marked this pull request as ready for review October 18, 2023 06:09
ClausHolbechArista
ClausHolbechArista approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing this.

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 18, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team October 18, 2023 10:51
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 18, 2023
carlbuchmann
carlbuchmann approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, negative test case provides correct results.

@carlbuchmann carlbuchmann merged commit 5d1f76c into aristanetworks:devel Oct 18, 2023
36 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
rn: Feat(pyavd) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shivani-gslab @carlbuchmann @ClausHolbechArista