Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Set spanning-tree priority per VLAN #3273

Merged
merged 1 commit into from Dec 19, 2023
Merged

Feat(eos_designs): Set spanning-tree priority per VLAN #3273

merged 1 commit into from Dec 19, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Set spanning-tree priority per VLAN

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Allow setting spanning_tree_priority under l2vlans and svis for rapid-pvst only.
  • Update schema doc for node setting to hint to this setting.

How to test

  • Added molecule case for rapid-pvst in eos_designs including this new feature.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 20, 2023
@carlbuchmann carlbuchmann self-requested a review October 20, 2023 16:32
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ankudinov ankudinov self-requested a review December 4, 2023 11:25
ankudinov
ankudinov reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments above, happy to LGTM if changes are not feasible at this stage.

ansible_collections/arista/avd/roles/eos_designs/python_modules/base/avdstructuredconfig.py Outdated Show resolved Hide resolved
...le_collections/arista/avd/roles/eos_designs/python_modules/network_services/spanning_tree.py Show resolved Hide resolved
jrecchia1029
jrecchia1029 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@jrecchia1029 jrecchia1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ankudinov
ankudinov approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/Set-spanning-tree-priority-per-VLAN branch from 20bacba to 1a474fc Compare December 19, 2023 12:32
@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 19, 2023
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann merged commit 9e8ca36 into aristanetworks:devel Dec 19, 2023
38 checks passed
gmuloc pushed a commit to gmuloc/avd that referenced this pull request Dec 20, 2023
@ClausHolbechArista @gmuloc
Feat(eos_designs): Set spanning-tree priority per VLAN (aristanetwork…
fe6235f 
…s#3273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankudinov ankudinov ankudinov approved these changes

@jrecchia1029 jrecchia1029 jrecchia1029 approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
EPIC - Improve Campus Support rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ClausHolbechArista @ankudinov @jrecchia1029 @carlbuchmann