Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add enabled flag to router traffic-engineering #3280

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 20, 2023

Change Summary

This is to be able to render alone

router traffic-engineering

Today it is required to do:

router_traffic_engineering: {}

Which we want to avoid in AVD (having to define an empty dict to generate some conf

The flags is for now optional (it only renders a line in the documentation. It WILL become mandatory in AVD 5.0.0

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding enabled flag to router_traffic_engineering

How to test

molecule test allow to verify in doc

Checklist

User Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team October 20, 2023 13:07
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 20, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally

@carlbuchmann carlbuchmann merged commit 51d521c into aristanetworks:devel Oct 24, 2023
46 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants