Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Support for "agents" config #3282

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 20, 2023

Change Summary

Render stuff like:

agent BLAH environment BLAH=BLAH
agent KernelFib environment TOTO=TEAH

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

ceos2(config)#show cli commands | grep agent
[no|default] agent AGENT environment ENVIRON_CONFIG
[no|default] agent AGENT memory allocations heap fastbin limit SIZE
[no|default] agent AGENT shutdown [ supervisor ( active | standby | all ) ]
[no|default] agent AGENT_NAME warm-restart ( ( allowed ALLOWED_NUM ) | ( window WINDOW_NUM ) | always )
agent fatal-error action ACTION
ceos2(config)#agent BLAH environment ?
  EXPR  Agent environment configuration in the form of VAR1=VAL1:VAR2=VAL2:...
    agents:
      - name: <str>
        environments:
          - name: <str>
            value: <str>

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 20, 2023 13:00
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 20, 2023
@gmuloc gmuloc added EPIC - AVD AutoVPN/WAN and removed role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 20, 2023
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 20, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Produce agents config Feat(eos_cli_config_gen): Support for "agents" config Oct 23, 2023
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 23, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update eos_cli_config_gen input-variable.md

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 6102dcf into aristanetworks:devel Oct 24, 2023
39 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants