Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Implement speed for management interfaces #3284

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 20, 2023

Change Summary

Added same speed key as under ethernet interfaces under management interfaces

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

copy of model

How to test

molecule
added a molecule test for ethernet-interfaces in eos_cli_config_gen scenario as it was missing !?! (ok it was in other eos_designs ones)

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 20, 2023 15:36
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 20, 2023
@gmuloc gmuloc changed the title Feat(eos_cli_comfig_gen): Implement speed for management interfaces Feat(eos_cli_config_gen): Implement speed for management interfaces Oct 20, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Oct 20, 2023
@gmuloc gmuloc requested a review from a team October 23, 2023 08:17
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Oct 23, 2023
@ClausHolbechArista ClausHolbechArista merged commit 29eab24 into aristanetworks:devel Oct 23, 2023
39 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
@gmuloc gmuloc removed the role: eos_designs issue related to eos_designs role label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants