Fix(eos_cli_config_gen): l2_mtu under port_channel_interfaces #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
gmuloc
approved these changes
Oct 24, 2023
gmuloc
added
the
one approval
jonxstill
approved these changes
Oct 24, 2023
carlbuchmann
removed
the
one approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix l2_mtu under port_channel_interfaces
Related Issue(s)
Fixes #3290
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Feature was never implemented for port-channel interfaces, but "sneaked" in to the docs during the work on schemas. Since it was never working, the tests did not show a change at the time.
Adding the feature and a test in
eos_cli_config_gen. Also rerunning molecule for a few scenarios foreos_designswhere the use ofport_profilescaused the l2_mtu to be set on the port_channel_interfaces. (This is what caused us to assume it was there when we built schemas).How to test
Checklist
User Checklist
Repository Checklist