Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Improve custom python class API for interface descriptions #3311

Merged
merged 4 commits into from Dec 14, 2023
Merged

Feat(eos_designs): Improve custom python class API for interface descriptions #3311

merged 4 commits into from Dec 14, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Oct 31, 2023 •
edited

Change Summary

Improve custom python class API for interface descriptions

Related Issue(s)

Part of #3306

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Add new API functions for custom python modules for interface descriptions.
  • Use a data class to pass data between AVD and the interface description class.

How to test

  • Replaced existing custom class with a new one using the new API - no changes!
  • Replaced existing custom jinja for spines with the old custom python class - no changes!
  • No other changes in molecule.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Oct 31, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Oct 31, 2023
Open
5 tasks
@tgodaA tgodaA added this to In progress in US-PROJECT-02 via automation Nov 7, 2023
tgodaA
tgodaA previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chetryan
chetryan reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just 2 NIT questions

...vd/molecule/eos_designs_unit_tests/custom_modules/custom_interface_descriptions_with_data.py Outdated

return ""

def underlay_port_channel_interfaces(self, data: InterfaceDescriptionData) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be underlay_port_channel_interface ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClausHolbechArista

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 21a1542

...sta/avd/molecule/eos_designs_unit_tests/inventory/group_vars/CUSTOM_PYTHON_MODULES_TESTS.yml Show resolved Hide resolved
@tgodaA tgodaA added the one approval This PR has one approval and is only missing one more. label Nov 30, 2023
@carlbuchmann carlbuchmann added this to the v4.5.0 milestone Dec 5, 2023
@carlbuchmann carlbuchmann force-pushed the feat/eos_designs/improve-custom-python-class-api branch from 9450a52 to 21a1542 Compare December 14, 2023 00:11
@carlbuchmann carlbuchmann self-requested a review December 14, 2023 00:12
carlbuchmann
carlbuchmann approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

US-PROJECT-02 automation moved this from In progress to Reviewer approved Dec 14, 2023
@tgodaA tgodaA dismissed their stale review December 14, 2023 02:07

1 last comment has to be checked and addressed.

US-PROJECT-02 automation moved this from Reviewer approved to Review in progress Dec 14, 2023
tgodaA
tgodaA approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

US-PROJECT-02 automation moved this from Review in progress to Reviewer approved Dec 14, 2023
@ClausHolbechArista ClausHolbechArista merged commit acd7adb into aristanetworks:devel Dec 14, 2023
38 checks passed
US-PROJECT-02 automation moved this from Reviewer approved to Done Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@chetryan chetryan chetryan left review comments

@tgodaA tgodaA tgodaA approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
US-PROJECT-02
Done
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ClausHolbechArista @carlbuchmann @tgodaA @chetryan