Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add hardware_offload feature to flow_tracking.sampled #3318

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Feat(eos_cli_config_gen): Add hardware_offload feature to flow_tracking.sampled #3318

merged 5 commits into from
Nov 8, 2023

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Oct 31, 2023

Change Summary

Add the hardware_offload feature to the flow_tracking sampled

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

molecule converge -s eos_cli_config_gen -- --limit flow-tracking

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested review from a team as code owners October 31, 2023 19:27
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 31, 2023
@tgodaA tgodaA added this to In progress in US-PROJECT-02 via automation Nov 1, 2023
@tgodaA tgodaA requested a review from chetryan November 1, 2023 17:28
@tgodaA tgodaA requested a review from gmuloc November 3, 2023 14:53
@gmuloc gmuloc requested a review from a team November 3, 2023 15:49
chetryan
chetryan approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodaA tgodaA requested a review from gmuloc November 7, 2023 17:43
US-PROJECT-02 automation moved this from In progress to Reviewer approved Nov 8, 2023
@ClausHolbechArista ClausHolbechArista merged commit 399cfcf into aristanetworks:devel Nov 8, 2023
39 checks passed
US-PROJECT-02 automation moved this from Reviewer approved to Done Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@chetryan chetryan chetryan approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@tgodaA tgodaA

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
US-PROJECT-02
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tgodaA @gmuloc @ClausHolbechArista @chetryan @JulioPDX