Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add profile and policy in adaptive-virtual-topology #3351

Merged
merged 25 commits into from
Nov 25, 2023
Merged

Feat(eos_cli_config_gen): Add profile and policy in adaptive-virtual-topology #3351

merged 25 commits into from
Nov 25, 2023

Conversation

harshitk-arista
Copy link
Contributor

@harshitk-arista harshitk-arista commented Nov 15, 2023 •
edited
Loading

Change Summary

Add models for AVT profiles, AVT policies and VRF configuration (which brings together AVT profiles and policies)

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

cf schema update

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@harshitk-arista harshitk-arista requested review from a team as code owners November 15, 2023 18:59
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 15, 2023
@harshitk-arista harshitk-arista changed the title Feat(eos_cli_config_gen: Add profile and policy in adaptive-virtual-topology Feat(eos_cli_config_gen): Add profile and policy in adaptive-virtual-topology Nov 15, 2023
gmuloc
gmuloc reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments for now

...ctions/arista/avd/roles/eos_cli_config_gen/templates/eos/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/eos/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/eos/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/eos/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...sta/avd/roles/eos_cli_config_gen/templates/documentation/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...sta/avd/roles/eos_cli_config_gen/templates/documentation/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...sta/avd/roles/eos_cli_config_gen/templates/documentation/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...sta/avd/roles/eos_cli_config_gen/templates/documentation/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
...sta/avd/roles/eos_cli_config_gen/templates/documentation/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
@gmuloc gmuloc requested a review from a team November 20, 2023 13:31
harshitk-arista and others added 4 commits November 20, 2023 22:28
@harshitk-arista @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
6a0b7c3 
…tes/documentation/router-adaptive-virtual-topology.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@harshitk-arista @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
8fa20e4 
…tes/documentation/router-adaptive-virtual-topology.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@gmuloc
Merge branch 'devel' into feat/avtpolicy
79b6f4e
@gmuloc
Refactor: Rename match_clauses to matches and run molecule
4a9e893
gmuloc
gmuloc approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this contribution!

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Nov 23, 2023
jonxstill
jonxstill approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against a CloudEOS instance - config was accepted and looks good.

@carlbuchmann carlbuchmann merged commit 62dfd69 into aristanetworks:devel Nov 25, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista left review comments

@gmuloc gmuloc gmuloc approved these changes

@jonxstill jonxstill jonxstill approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@harshitk-arista harshitk-arista

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harshitk-arista @gmuloc @jonxstill @ClausHolbechArista @carlbuchmann