Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_validate_state): ANTA Add eAPI HTTPS SSL profile test #3357

Merged
merged 5 commits into from Dec 14, 2023

Conversation

MaheshGSLAB
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB commented Nov 17, 2023

Change Summary

Added ANTA test case to verify eAPI HTTPS SSL profile is configured and state is valid.

Related Issue(s)

Fixes #2850

Component(s) name

arista.avd.eos_validate_state ANTA Preview

Proposed changes

  1. Added ANTA test case for eAPI HTTPS SSL profile status

How to test

Add below details in input group vars to generate the config

custom_structured_configuration_management_api_http:
  https_ssl_profile: ARISTA-AVD

Once the config pushed on the device then run eos_validate_state molecule.

  1. Testcase get pass when a ssl profile is configured with state as valid.
test_id,node,test_category,test_description,test,result,failure_reason
1,s1-leaf1,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,PASS,
2,s1-leaf2,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,PASS,
3,s1-leaf3,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,PASS,
4,s1-leaf4,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,PASS,
5,s1-spine1,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,PASS,
6,s1-spine2,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,PASS,
  1. Testcase get failed with correct message if input profile is not matched or not configured.
test_id,node,test_category,test_description,test,result,failure_reason
1,s1-leaf1,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,FAIL,eAPI HTTPS server SSL profile (Invalid-ARISTA-AVD) is misconfigured or invalid
2,s1-leaf2,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,FAIL,eAPI HTTPS server SSL profile (Invalid-ARISTA-AVD) is misconfigured or invalid
3,s1-leaf3,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,FAIL,eAPI HTTPS server SSL profile (Invalid-ARISTA-AVD) is misconfigured or invalid
4,s1-leaf4,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,FAIL,eAPI HTTPS server SSL profile (Invalid-ARISTA-AVD) is misconfigured or invalid
5,s1-spine1,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,FAIL,eAPI HTTPS server SSL profile (Invalid-ARISTA-AVD) is not configured
6,s1-spine2,SSL,eAPI HTTPS server SSL profile is configured and valid,SSL,FAIL,eAPI HTTPS server SSL profile (Invalid-ARISTA-AVD) is misconfigured or invalid
  1. Testcase will not run if ssl profile var is not defined in input group vars.
  2. Ansible task get fail in case the SSL profile is invalid as https server not running with invalid profile hence eapi connection broke. Need to look more on it

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 1, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Dec 7, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after changing the note in the documentation.

@gmuloc gmuloc self-requested a review December 12, 2023 13:18
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok if doc is all right when CI finishes

arista and others added 5 commits December 14, 2023 12:37
issue-2850: Fix the linting issue

issue-2850: Fix the get method for nested dict

issue-2850: updated the code to use anta description, categories, tag and logged

issue-2850: fix the flake8 errors

issue-2850: removed security from acronym categories

issue-2850: Updated the molecule files

issue-2850: Updated the MD file
@ClausHolbechArista ClausHolbechArista merged commit ae314a0 into aristanetworks:devel Dec 14, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Validate SSL profiles that use certificates
5 participants