Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen, eos_designs): BGP VRF Prefix-lists not allowed outside of AF #3358

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Nov 17, 2023

Change Summary

Fix BGP VRF Prefix-lists not allowed outside of AF

Related Issue(s)

Fixes #3348

Component(s) name

arista.avd.<role-name>

Proposed changes

  • Deprecate router_bgp.vrfs[].neighbors[].prefix_list_in in favor of router_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_in.
  • Deprecate router_bgp.vrfs[].neighbors[].prefix_list_out in favor of router_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_out.
  • Adding support for ipv6 prefix-list in/out under VRFs.
  • Updating eos_designs to not produce the wrong config and handle both v4 and v6.

How to test

  • Updated molecule scenario eos_cli_config_gen to use the new model. Added to eos_cli_config_gen_deprecated_vars to test old model plus various combinations.
  • Updated molecule eos_designs_unit_tests to cover v4 and v6 prefix-lists.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 17, 2023
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): BGP VRF Prefix-lists not allowed outside of AF Fix(eos_cli_config_gen, eos_designs): BGP VRF Prefix-lists not allowed outside of AF Nov 17, 2023
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Nov 17, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review November 17, 2023 11:33
@ClausHolbechArista
Copy link
Contributor Author

Hi @tosha25, this fixes the issue you submitted and while I was at it, I also added support for IPv6 prefix-lists.
If you have a chance, I would appreciate if you could test this out. Otherwise we will test it on our side and get it into the next release.

@gmuloc gmuloc requested a review from a team November 20, 2023 13:30
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@gmuloc gmuloc requested a review from a team November 21, 2023 09:19
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Nov 21, 2023
@gmuloc gmuloc added this to the v4.5.0-dev2 milestone Nov 21, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed:

  • unit test cases
  • schema
  • updated template and module

@carlbuchmann carlbuchmann merged commit ae4516e into aristanetworks:devel Nov 21, 2023
39 checks passed
@ClausHolbechArista ClausHolbechArista modified the milestones: v4.5.0-dev2, v4.5.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_cli_config_gen|eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefix_lists are rendered at the wrong level by eos_desings role
3 participants