New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_cli_config_gen, eos_designs): BGP VRF Prefix-lists not allowed outside of AF #3358
Fix(eos_cli_config_gen, eos_designs): BGP VRF Prefix-lists not allowed outside of AF #3358
Conversation
Hi @tosha25, this fixes the issue you submitted and while I was at it, I also added support for IPv6 prefix-lists. |
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed:
- unit test cases
- schema
- updated template and module
Change Summary
Fix BGP VRF Prefix-lists not allowed outside of AF
Related Issue(s)
Fixes #3348
Component(s) name
arista.avd.<role-name>
Proposed changes
router_bgp.vrfs[].neighbors[].prefix_list_in
in favor ofrouter_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_in
.router_bgp.vrfs[].neighbors[].prefix_list_out
in favor ofrouter_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_out
.How to test
eos_cli_config_gen
to use the new model. Added toeos_cli_config_gen_deprecated_vars
to test old model plus various combinations.eos_designs_unit_tests
to cover v4 and v6 prefix-lists.Checklist
User Checklist
Repository Checklist