Fix(eos_cli_config_gen): Correct syntax for "redistribute bgp" in router bgp #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
carlbuchmann
changed the title
ClausHolbechArista
changed the title
...e_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-base.yml
Show resolved
Hide resolved
carlbuchmann
changed the title
carlbuchmann
changed the title
carlbuchmann
force-pushed
the
fix-3356
branch
from
8cb14c6
to
b75d568
Compare
ClausHolbechArista
approved these changes
Dec 5, 2023
ClausHolbechArista
added
the
one approval
gmuloc
approved these changes
Dec 5, 2023
gmuloc
removed
the
one approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Correct syntax in "restribute bgp leaked" in router bgp.
includestatement being generated when source routing protocol is bgpleakedis required, include_leaked: true is no longer required whenredistributing bgpin router bgp. Instead it will automatically be generated when the source protocol is BGP.Related Issue(s)
Fixes #3356
Component(s) name
arista.avd.eos_cli_config_genProposed changes
In
router_bgpjinja template add logic to look if source_protocol == bgp, then automatically generateleaked.How to test
See new molecule test cases.
Checklist
Repository Checklist