Fix(eos_cli_config_gen): MAC Security key fallback configured even if set to false #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
gmuloc
reviewed
Dec 15, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/mac-security.j2
Outdated
Show resolved
Hide resolved
…tes/eos/mac-security.j2 Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added a check if the MAC Security Key fallback option is true and only configure it when it is true
Related Issue(s)
Fixes #3436
Component(s) name
arista.avd.eos_cli_config_genProposed changes
added a check that fallback is true
{% if connection_key.fallback is arista.avd.defined and connection_key.fallback %}
How to test
mac_security:
profiles:
- name: A3
cipher: aes256-gcm-xpn
connection_keys:
- id: ab
encrypted_key: 10195F4C5144405A
fallback: false
Checklist
User Checklist
Repository Checklist