Fix(eos_validate_state): ANTA Fix AvdTestBase structured_config objects #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmuloc
reviewed
Dec 19, 2023
|
|
||
| # Check if struct_cfg is a dict or behaves like a dict (e.g. Ansible 'hostvars' object) | ||
| if not isinstance(struct_cfg, (dict, Mapping)): | ||
| # Check if struct_cfg is a mapping object (e.g. Ansible 'hostvars' object or regular dict) |
There was a problem hiding this comment.
Suggested change
| # Check if struct_cfg is a mapping object (e.g. Ansible 'hostvars' object or regular dict) | |
| # Check if struct_cfg is a Mapping object (e.g. Ansible 'hostvars' object or regular dict) |
|
coffee needed ☕ |
ClausHolbechArista
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Re-adding some changes of commit 8f62845 that was lost in commit f821243 of PR #3407
Fixing other issues. See Proposed changes below.
Related Issue(s)
N/A
Component(s) name
arista.avd.eos_validate_stateANTA ModeProposed changes
get_host_struct_cfgmethod name toget_host_structured_configfor claritycprofile()Mappingfrom typingHow to test
Molecule
Checklist
User Checklist
Repository Checklist