Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): add sFlow sample input subinterface support #3457

Merged
merged 2 commits into from Jan 3, 2024

Conversation

AlexGayed
Copy link
Contributor

@AlexGayed AlexGayed commented Dec 21, 2023

Change Summary

add sFlow sample input subinterface support

Related Issue(s)

Fixes #3252

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

sflow:
  sample_input_subinterface: <bool>

How to test

Updated molecule scenario

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@AlexGayed AlexGayed requested review from a team as code owners December 21, 2023 20:26
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 21, 2023
@AlexGayed
Copy link
Contributor Author

AlexGayed commented Dec 21, 2023

The current ordering of sFlow doesn't match but I didn't want to break the current implementation

dc2-leaf1a(config)#sh cli commands | i sflow
[no|default] sflow [ ( VRF_VRF_KW ( VRF_VRF_DYNAMIC | VRF_VRF_DEFAULT ) ) ] destination DESTINATION [ PORT ]
[no|default] sflow [ ( VRF_VRF_KW ( VRF_VRF_DYNAMIC | VRF_VRF_DEFAULT ) ) ] source SOURCE
[no|default] sflow [ ( VRF_VRF_KW ( VRF_VRF_DYNAMIC | VRF_VRF_DEFAULT ) ) ] source-interface IPINTF
[no|default] sflow extension bgp
[no|default] sflow extension mpls
[no|default] sflow extension router
[no|default] sflow extension switch
[no|default] sflow extension tunnel ipv4 egress
[no|default] sflow hardware acceleration
[no|default] sflow hardware acceleration datagram threshold transmission ( BYTES bytes ) | ( SAMPLES samples )
[no|default] sflow hardware acceleration module CARD_LIST
[no|default] sflow hardware acceleration profile sflowaccel-v2
[no|default] sflow hardware acceleration sample RATE
[no|default] sflow interface disable default
[no|default] sflow interface egress enable default
[no|default] sflow interface egress unmodified enable default
[no|default] sflow polling-interval POLLING_INTERVAL
[no|default] sflow run
[no|default] sflow sample ( RATE | ( dangerous DANGEROUS_RATE ) )
[no|default] sflow sample include drop reason acl
[no|default] sflow sample input subinterface
[no|default] sflow sample output ( interface | subinterface )
[no|default] sflow sample output portchannel ifindex IFINDEX_MODE
[no|default] sflow sample rewrite dscp
[no|default] sflow sample truncate size SIZE
[no|default] sflow sample vxlan header strip

Copy link
Contributor

@philippebureau philippebureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit de33210 into aristanetworks:devel Jan 3, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sflow - Sample Input
3 participants