Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): add sFlow sample output subinterface support #3458

Conversation

philippebureau
Copy link
Contributor

Change Summary

add sflow sample output subinterface to eos_cli_config_gen

Related Issue(s)

N/A

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

sflow:
sample_output_subinterface:

How to test

check molecule test update

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@philippebureau philippebureau requested review from a team as code owners December 22, 2023 17:16
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 22, 2023
@ClausHolbechArista
Copy link
Contributor

I merged the input variant. Please resolve all the conflicts.

Copy link

github-actions bot commented Jan 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jan 3, 2024
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista
Copy link
Contributor

@philippebureau moving this one to draft. It needs some attention to rebase, resolve conflicts and rerun pre-commit.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft January 23, 2024 08:53
@Shivani-gslab
Copy link
Contributor

Need to rebase and resolve conflicts in this PR.
Otherwise LGTM, tested it on ATD lab.

Copy link

github-actions bot commented Mar 4, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 4, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review March 4, 2024 07:13
@ClausHolbechArista ClausHolbechArista merged commit b48d3e3 into aristanetworks:devel Mar 14, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants