Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(plugins): Preview - New arista.avd.deploy_to_cv role #3466

Merged
merged 69 commits into from
Feb 9, 2024
Merged

Feat(plugins): Preview - New arista.avd.deploy_to_cv role #3466

merged 69 commits into from
Feb 9, 2024

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jan 3, 2024 •
edited
Loading

Change Summary

Preview - New arista.avd.deploy_to_cv role

Component(s) name

arista.avd.<role-name>

Proposed changes

Adding:

  • Auto-generated gRPC API with asyncio python bindings based on aristaproto library.
  • CVClient library wrapping gRPC API to provider more user-friendly functions.
  • deploy_to_cv package with all functionality required to deploy configs and tags to CV.
  • Ansible Action plugin arista.avd.deploy_to_cv which wraps the python code consumes data from structured configs etc.
  • Ansible Role arista.avd.deploy_to_cv to easily deploy things from a playbook.

See the preview docs for role documentation.

How to test

See the preview docs for role documentation.

Only tested manually. Molecule tests will be added in #3500 but those will most likely still require manual testing.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jan 3, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 5, 2024
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jan 5, 2024
Closed
4 tasks
@ClausHolbechArista ClausHolbechArista force-pushed the feat/plugins/new-cvp-integration-library branch from 435b15a to 29744b9 Compare January 15, 2024 06:39
@sugetha24 sugetha24 mentioned this pull request Jan 15, 2024
Merged
@ClausHolbechArista ClausHolbechArista changed the title Feat(plugins): New CloudVision integration Feat(plugins): Preview - New CloudVision integration Jan 17, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review January 17, 2024 12:13
gmuloc
gmuloc reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had time to go halfway through it but some initial comments

ansible_collections/arista/avd/plugins/action/deploy_to_cv.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/action/deploy_to_cv.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/action/deploy_to_cv.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/action/deploy_to_cv.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/modules/deploy_to_cv.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/tag.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/modules/deploy_to_cv.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/utils.py Show resolved Hide resolved
...e_collections/arista/avd/plugins/plugin_utils/cv_client/deploy_to_cv/deploy_configs_to_cv.py Show resolved Hide resolved
...e_collections/arista/avd/plugins/plugin_utils/cv_client/deploy_to_cv/deploy_configs_to_cv.py Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista changed the title Feat(plugins): Preview - New CloudVision integration Feat(plugins): Preview - New arista.avd.deploy_to_cv role Jan 18, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the feat/plugins/new-cvp-integration-library branch from 395109e to 2fabb3c Compare January 29, 2024 12:49
@philippebureau
Copy link
Contributor

we need to make sure the users are aware that we need to turn on studios end to end provisioning to enable the static studios

Also, the devices have to be on-boarded previously with the inventory studios. Should the avd role auto accept updates for devices in the inventory?

@ClausHolbechArista
Copy link
Contributor Author

we need to make sure the users are aware that we need to turn on studios end to end provisioning to enable the static studios

Also, the devices have to be on-boarded previously with the inventory studios. Should the avd role auto accept updates for devices in the inventory?

Thank you @philippebureau I will add these points to my tracker for future enhancements. This is all under preview for now, so I will fix it step by step.

gmuloc
gmuloc reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only went through the code (no testing as others have done it)
Almost all my comments can be punted to later except the one asking for potential wrong default value in the role I think.

ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/configlet.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/cv_client.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/configlet.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/exceptions.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/studio.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/deploy_to_cv/defaults/main/main.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/deploy_to_cv/README.md Show resolved Hide resolved
...e_collections/arista/avd/plugins/plugin_utils/cv_client/deploy_to_cv/verify_devices_on_cv.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/deploy_to_cv/models.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/deploy_to_cv/deploy_to_cv.py Outdated Show resolved Hide resolved
ClausHolbechArista and others added 14 commits February 9, 2024 11:52
@ClausHolbechArista
Accept non libyaml
f03604a
@ClausHolbechArista
Nicer error messages for missing devices listing only unique devices
014e8af
@ClausHolbechArista
Fix when missing inputs
62b6f4f
@ClausHolbechArista
Increase timeout 10>30 for SetSome
c73e625
@ClausHolbechArista
Improve error messages for missing devices
495c4e5
@ClausHolbechArista @noredistribution
Update ansible_collections/arista/avd/roles/deploy_to_cv/tasks/main.yml
3d464e3 
Co-authored-by: Tamas Plugor <41957075+noredistribution@users.noreply.github.com>
@ClausHolbechArista
Metadata Fixes
b5eff38
@ClausHolbechArista
Update metadata studio to latest schema
1c40106
@ClausHolbechArista
Increase timeout for tags and add more logging
014b695
@ClausHolbechArista
Address review comments
501a343
@ClausHolbechArista @gmuloc
Update ansible_collections/arista/avd/plugins/plugin_utils/cv_client/…
b43405a 
…client/cv_client.py

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@ClausHolbechArista
Unassign tags with same label but other value
6da89a6
@ClausHolbechArista
Update readme
6d78f62
@ClausHolbechArista
Update scopes
3f22a6f
@ClausHolbechArista ClausHolbechArista force-pushed the feat/plugins/new-cvp-integration-library branch from 2d254ce to 3f22a6f Compare February 9, 2024 10:53
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role labels Feb 9, 2024
@github-actions github-actions bot added filter: is_in_filter issue related to is_in_filter plugin filter: natural_sort issue related to natural_sort filter plugin type: Python filters labels Feb 9, 2024
carlbuchmann
carlbuchmann approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmuloc
gmuloc approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: ⚡ ⚡ ⚡

@gmuloc gmuloc merged commit aeda0c2 into aristanetworks:devel Feb 9, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugetha24 sugetha24 sugetha24 left review comments

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@noredistribution noredistribution Awaiting requested review from noredistribution

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
EPIC - AVD AutoVPN/WAN filter: is_in_filter issue related to is_in_filter plugin filter: natural_sort issue related to natural_sort filter plugin rn: Feat(plugins) state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation type: Python filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ClausHolbechArista @philippebureau @gmuloc @sugetha24 @carlbuchmann @noredistribution