Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Uplink p2p vrfs #3467

Merged
merged 45 commits into from Jan 26, 2024
Merged

Feat(eos_designs): Uplink p2p vrfs #3467

merged 45 commits into from Jan 26, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jan 3, 2024 •
edited

Change Summary

WIP

Related Issue(s)

Fixes #3004

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Move filtered tenants to shared_utils (if you know you know)
  • Add a new type for uplinks p2p-vrfs - this new type will pick up device VRFs from Tenants and create a l3 physical interface with one subinterface per VRF numbered using the vrf_id.
  • In a first go, the IP address per VRF will be picked up from the uplink_ipv4_pool and will be the same on every link and uses the same algorithm

How to test

Checklist

Reviewer checklist

  • sub interface description with whitespaces and vrf: <VRF> - is it ok? - changed to underscores

User Checklist

  • Need to discuss what should be configured on the subinterface and what should not
  • Need to make sure the VRF is properly configured on the uplink switch
  • Discuss default default description on the sub interfaces and physical interface
  • Routing protocol -> only BGP first then other protocols? What should be configured for BGP?

Future feature

  • Add new node types to support p2p-vrf without heavy customization.
  • Future nice to have: Build campus example leveraging this feature.
  • Add a key under tenants[tenant].vrfs[vrf] to specify the pool.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 3, 2024
ClausHolbechArista
ClausHolbechArista reviewed Jan 4, 2024
View reviewed changes
.../arista/avd/molecule/eos_designs_unit_tests/intended/configs/UPLINK_P2P_VRFS_TESTS_LEAF1.cfg Outdated Show resolved Hide resolved
.../arista/avd/molecule/eos_designs_unit_tests/intended/configs/UPLINK_P2P_VRFS_TESTS_LEAF1.cfg Show resolved Hide resolved
...ns/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/UPLINK_P2P_VRFS_TESTS.yml Outdated Show resolved Hide resolved
...ista/avd/roles/eos_designs/python_modules/interface_descriptions/avdinterfacedescriptions.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/ethernet_interfaces.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/misc.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Show resolved Hide resolved
ClausHolbechArista
ClausHolbechArista reviewed Jan 11, 2024
View reviewed changes
...ns/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/UPLINK_P2P_VRFS_TESTS.yml Outdated Show resolved Hide resolved
...ns/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/UPLINK_P2P_VRFS_TESTS.yml Show resolved Hide resolved
...ns/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/UPLINK_P2P_VRFS_TESTS.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts/uplinks.py Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-uplink-configuration.md Show resolved Hide resolved
@carlbuchmann carlbuchmann self-requested a review January 24, 2024 16:04
@gmuloc gmuloc mentioned this pull request Jan 25, 2024
Merged
4 tasks
@carlbuchmann carlbuchmann self-requested a review January 26, 2024 02:51
carlbuchmann
carlbuchmann approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment •
edited by gmuloc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested in lab with small topology

The following can be addressed after merging to devel:

  • The vrfs function should have the check for l3 services.
  • when uplink_type: p2p-vrfs require underlay_router: true.
  • Fix post validation error when leveraging ANTA CRITICAL Exception raised for test VerifyLLDPNeighbors (on device agg2): KeyError ('Ethernet1.20').
  • optional: add new node types to support p2p-vrf without heavy customization.
  • Future nice to have: Build campus example leveraging this feature.

@gmuloc
Copy link
Contributor Author

gmuloc commented Jan 26, 2024

address point number 2 by using guard on underlay_router true + l3_network_services true when uplink type is p2p-vrfs

@gmuloc
Copy link
Contributor Author

gmuloc commented Jan 26, 2024

Check excluding subinterfaces from ANTA

@ClausHolbechArista ClausHolbechArista mentioned this pull request Jan 26, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 26, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann merged commit b685e71 into aristanetworks:devel Jan 26, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role role: eos_validate_state state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for uplink_type: p2p-vrfs
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista