Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Minor container fixes #3474

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

ankudinov
Copy link
Contributor

Change Summary

This PR adds xz-utils to the base container, that is required for Docker import to work when D-in-D is installed.
It also adds /home/${USER}/.ansible/collections/ansible_collections/arista/avd explicitly to dev image, as otherwise mount to non-existing path can fail in some environments.

Component(s) name

containers

How to test

Merge to rebuild containers. Pull and check that xz-utils are installed.
The best way to test for mount issues to non-existing path is to start Codespace for AVD PR and check if AVD collection was installed successfully.
Once base is re-build, dev and universal builds must be triggered manually to get xz-utils.

@ClausHolbechArista ClausHolbechArista requested a review from a team January 8, 2024 15:17
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 8, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit c7a9105 into aristanetworks:devel Jan 8, 2024
38 checks passed
@ankudinov ankudinov deleted the minor-container-fixes branch January 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants