Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Preview - Generate CV Tags and metadata for WAN #3487

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Feat(eos_designs): Preview - Generate CV Tags and metadata for WAN #3487

merged 9 commits into from
Jan 12, 2024

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jan 11, 2024 •
edited
Loading

Depends on #3472 so rebase after that has merged.

Change Summary

Preview - Generate CV Tags for WAN

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 11, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Preview - Generate WAN Cloudvision Tags Feat(eos_designs): Preview - Generate CV Tags for WAN Jan 11, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Preview - Generate CV Tags for WAN Feat(eos_designs): Preview - Generate CV Tags and metadata for WAN Jan 12, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/wan-generate-metadata branch from ce2ad7a to 83e1c35 Compare January 12, 2024 15:41
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review January 12, 2024 15:42
gmuloc
gmuloc approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the comment can be pushed

gmuloc
gmuloc approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc mentioned this pull request Jan 12, 2024
Merged
34 tasks
@gmuloc gmuloc merged commit 2c393e4 into aristanetworks:devel Jan 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClausHolbechArista @gmuloc