-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support for tcp mss ceiling in router path selection #3489
Merged
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
amitsagar-arsita:tcp_mss
Jan 24, 2024
Merged
Feat(eos_cli_config_gen): Support for tcp mss ceiling in router path selection #3489
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
amitsagar-arsita:tcp_mss
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_path_selection.schema.yml
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jan 23, 2024
gmuloc
reviewed
Jan 23, 2024
...ollections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-path-selection.cfg
Outdated
Show resolved
Hide resolved
gmuloc
previously requested changes
Jan 23, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-path-selection.j2
Outdated
Show resolved
Hide resolved
gmuloc
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding eos_cli_config_get model for tcp mss ceiling under router path selection.
Change Summary
Related Issue(s)
Fixes #3423
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Changed the router path selection model for tcp mss.
How to test
Tested using molecule.
Have updated existing molecule scenarios to accommodate this use case.
Checklist
User Checklist
Repository Checklist