Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add vxlan_interface.Vxlan1.multicast_headend_replication #3490

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Feat(eos_cli_config_gen): Add vxlan_interface.Vxlan1.multicast_headend_replication #3490

merged 4 commits into from
Jan 24, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jan 15, 2024 •
edited
Loading

Change Summary

Add headend_replication to vxlan_interface.Vxlan1

Related Issue(s)

Fixes #3095

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

User Checklist

  • Verify the command ordering on EOS

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab requested review from a team as code owners January 15, 2024 07:11
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 15, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): add headend-replication key to vxlan_interface.Vxlan1 dict Feat(eos_cli_config_gen): add headend-replication key to vxlan_interface.Vxlan1 Jan 15, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): add headend-replication key to vxlan_interface.Vxlan1 Feat(eos_cli_config_gen): add headend_replication key to vxlan_interface.Vxlan1 Jan 15, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): add headend_replication key to vxlan_interface.Vxlan1 Feat(eos_cli_config_gen): Add vxlan_interface.Vxlan1.multicast_headend_replication Jan 15, 2024
@Shivani-gslab Shivani-gslab force-pushed the vxlan_interface branch 2 times, most recently from 69219c3 to 423bad8 Compare January 16, 2024 07:20
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 16, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team January 16, 2024 12:32
gmuloc
gmuloc reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good! Would it make sense to add something in documentation?

gmuloc
gmuloc reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add something in the documentation in this section: https://github.com/aristanetworks/avd/blob/devel/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/vlan-interfaces.j2#L11

@gmuloc gmuloc removed the one approval This PR has one approval and is only missing one more. label Jan 22, 2024
@Shivani-gslab
Copy link
Contributor Author

Can you also add something in the documentation in this section: https://github.com/aristanetworks/avd/blob/devel/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/vlan-interfaces.j2#L11

Added!

@ClausHolbechArista ClausHolbechArista requested a review from a team January 24, 2024 11:32
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 24, 2024
gmuloc
gmuloc approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@gmuloc gmuloc merged commit b35849b into aristanetworks:devel Jan 24, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): add headend-replication key to vxlan_interface.Vxlan1 dict
3 participants
@Shivani-gslab @gmuloc @ClausHolbechArista