Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Fix invalid valid value for ip_security.sa_policies.esp.encryption #3499

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Fix invalid valid value for ip_security.sa_policies.esp.encryption

Related Issue(s)

Fixes #3496

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Fix of typo in the schema for ip_security.sa_policies.esp.encryption

  • aes256gcm256 -> aes256gcm128

Verified available options on EOS 4.31.1:

eos(config-s-claus-ipsec-sa)#esp encryption ?
  aes128        AES - 128-bit Advanced Encryption Standard
  aes128gcm128  128 bit AES-GCM with 128 bit ICV
  aes128gcm64   128 bit AES-GCM with 64 bit ICV
  aes256        AES - 256-bit Advanced Encryption Standard
  aes256gcm128  256 bit AES-GCM with 128 bit ICV
  null          Null Encryption
  <cr>          

How to test

N/A

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista
Copy link
Contributor Author

@gusmb

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 36ff26b into aristanetworks:devel Jan 15, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(eos_cli_config_gen): Add missing IP security SA encryption values to schema
3 participants