Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Reordering router adaptive-virtual-topology / router path-selection #3505

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jan 16, 2024

Change Summary

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

put router adaptive-virtual-topology and router l2-vpn before router path-selection

How to test

Check things in CLI (EOS 4.31)

!
router adaptive-virtual-topology
   zone 42 id 42
!
router l2-vpn
   arp learning bridged
!
router path-selection
   peer dynamic source stun
   !

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners January 16, 2024 17:08
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Jan 16, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team January 16, 2024 18:09
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 16, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 8495b94 into aristanetworks:devel Jan 17, 2024
40 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants