Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Set BFD neighbor and per-link in port-channel interfaces #3509

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Feat(eos_cli_config_gen): Set BFD neighbor and per-link in port-channel interfaces #3509

merged 5 commits into from
Jan 24, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jan 17, 2024 •
edited
Loading

Change Summary

Setting BFD neighbor and per-link in port-channel interfaces.
Setting local-address to router_bfd.

Related Issue(s)

Fixes #3250

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

User Checklist

  • Verify the command ordering on EOS

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab requested review from a team as code owners January 17, 2024 10:00
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 17, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team January 19, 2024 08:00
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 19, 2024
@Shivani-gslab Shivani-gslab force-pushed the #issue3250 branch 2 times, most recently from 181bccd to 0c88b10 Compare January 19, 2024 08:16
@ClausHolbechArista ClausHolbechArista dismissed their stale review January 22, 2024 19:26

More changes needed.

@ClausHolbechArista ClausHolbechArista removed the one approval This PR has one approval and is only missing one more. label Jan 22, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft January 23, 2024 06:36
@Shivani-gslab Shivani-gslab marked this pull request as ready for review January 24, 2024 07:02
bjmeuer
bjmeuer approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@bjmeuer bjmeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit e18dab6 into aristanetworks:devel Jan 24, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjmeuer bjmeuer bjmeuer approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port Channel - Set BFD Neighbor
3 participants
@Shivani-gslab @bjmeuer @ClausHolbechArista