Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: rename repo ansible-avd -> avd #3513

Merged
merged 4 commits into from Jan 19, 2024

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Jan 18, 2024

Change Summary

Update repo URL and name from ansible-avd to avd.

This will remain a draft until change the repo name from ansible-avd to avd.
CI should be run after the repo rename to ensure Collection code testing / Validate mkdoc content is successful

Note: I didn't update any of the Ansible changelog fragments backups or artifacts.

@pmprado
Copy link
Contributor

pmprado commented Jan 18, 2024

Probably not very important... but this example mentions ansible-avd:

├── git_projects
│   ├── avd
│   ├── ansible-cvp
│   ├── ansible-avd-cloudvision-demo
│   ├── Makefile

This is in docs/contribution/setup-environment.html

LGTM otherwise!

@ClausHolbechArista
Copy link
Contributor

@pmprado the directory you refer to is mentioning a different repo which is not being renamed here: https://github.com/arista-netdevops-community/ansible-avd-cloudvision-demo

Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search for ansible-avd lists around 91 files for me. Not all of the are relevant.
Nevertheless, it's feasible to this about:

  • AVD examples. Currently all configs, etc. will be created in ansible-avd-examples. Should this be renamed or we keep it as is for now?
  • There are some smaller files in ansible_collections/arista/avd/ that are not part of the PR. Like utils.py

Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann marked this pull request as ready for review January 19, 2024 13:42
@carlbuchmann carlbuchmann requested review from a team as code owners January 19, 2024 13:42
@carlbuchmann carlbuchmann merged commit cbc8330 into aristanetworks:devel Jan 19, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Doc role: eos_designs issue related to eos_designs role role: eos_validate_state state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants