-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Performance improvements #3521
Merged
gmuloc
merged 18 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/performance-improvements
Jan 26, 2024
Merged
Refactor: Performance improvements #3521
gmuloc
merged 18 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/performance-improvements
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: documentation
Improvements or additions to documentation
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
type: Python filters
role: eos_designs
issue related to eos_designs role
labels
Jan 22, 2024
gmuloc
reviewed
Jan 26, 2024
ansible_collections/arista/avd/plugins/modules/validate_and_template.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/schema/avdtojsonschemaconverter.py
Outdated
Show resolved
Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml
Show resolved
Hide resolved
…mplate.py Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…tojsonschemaconverter.py Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
gmuloc
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI finishes
⚡ ⚡ ⚡
carlbuchmann
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once CI completes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Refactor
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
type: Python filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Performance improvements in eos_designs and common schema tooling
Proposed changes
Based on cProfiling this focuses on the most time impacting areas
How to test
Checklist
User Checklist
Repository Checklist