Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for monitor layer1 #3540

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jan 24, 2024

Change Summary

Adding monitor_layer1 data-model

Related Issue(s)

Fixes #3338

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

molecule converge -s eos_cli_config_gen

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab requested review from a team as code owners January 24, 2024 13:42
@Shivani-gslab Shivani-gslab self-assigned this Jan 24, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 24, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft January 24, 2024 13:59
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Initial add of monitor layer1 Feat(eos_cli_config_gen): A support for monitor layer1 Jan 24, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): A support for monitor layer1 Feat(eos_cli_config_gen): Add support for monitor layer1 Jan 24, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review January 24, 2024 15:16
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: conflict PR with conflict labels Jan 29, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

chetryan and others added 10 commits January 31, 2024 10:33
…s/schema_fragments/monitor_layer1.schema.yml

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…s/schema_fragments/monitor_layer1.schema.yml

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…s/schema_fragments/monitor_layer1.schema.yml

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…s/schema_fragments/monitor_layer1.schema.yml

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…tes/eos-device-documentation.j2

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Copy link

github-actions bot commented Feb 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Feb 6, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

github-actions bot commented Feb 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Feb 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 7, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Shivani-gslab Shivani-gslab force-pushed the monitor_layer1 branch 2 times, most recently from 9b3cec7 to b4d3f04 Compare February 14, 2024 05:51
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the pickle file. Otherwise looks good.

@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label Feb 16, 2024
Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit ee3ee2f into aristanetworks:devel Feb 16, 2024
41 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SYSLOG based alerting on optical thresholds
4 participants