New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for monitor layer1 #3540
Feat(eos_cli_config_gen): Add support for monitor layer1 #3540
Conversation
6c37165
to
f55fec5
Compare
34628ab
to
19f07a6
Compare
19f07a6
to
2cf3432
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2cf3432
to
7c34bce
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
…s/schema_fragments/monitor_layer1.schema.yml Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…s/schema_fragments/monitor_layer1.schema.yml Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…s/schema_fragments/monitor_layer1.schema.yml Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…s/schema_fragments/monitor_layer1.schema.yml Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
…tes/eos-device-documentation.j2 Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
58e858f
to
d296854
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
d296854
to
68ce5dd
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/monitor-layer1.md
Outdated
Show resolved
Hide resolved
9b3cec7
to
b4d3f04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the pickle file. Otherwise looks good.
ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.pickle
Outdated
Show resolved
Hide resolved
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.schema.pickle
Outdated
Show resolved
Hide resolved
b4d3f04
to
241c771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Summary
Adding monitor_layer1 data-model
Related Issue(s)
Fixes #3338
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
molecule converge -s eos_cli_config_gen
Checklist
User Checklist
Repository Checklist