Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support disabling hardware encryption for ip security #3550

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Feat(eos_cli_config_gen): Support disabling hardware encryption for ip security #3550

merged 2 commits into from
Jan 26, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jan 26, 2024 •
edited by carlbuchmann
Loading

Change Summary

Support disabling hardware encryption for ip security

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add a key

ip_security:
  hardware_encryption_disabled: <bool>

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners January 26, 2024 08:59
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 26, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team January 26, 2024 12:39
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 26, 2024
carlbuchmann
carlbuchmann approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit bc72f69 into aristanetworks:devel Jan 26, 2024
45 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista