Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): management interface for 750 platforms #3558

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Fix(eos_designs): management interface for 750 platforms #3558

merged 6 commits into from
Feb 2, 2024

Conversation

matthewgottlieb
Copy link
Contributor

@matthewgottlieb matthewgottlieb commented Jan 28, 2024 •
edited
Loading

Change Summary

The default eos_designs platform settings group the modular 750 platform (including specific names for its 5-slot and 8-slot variants) in with fixed platforms, which have different names for their management interfaces. This change corrects the default management interface for the 750 platform to Management0.

Related Issue(s)

Fixes #3557

Component(s) name

arista.avd.eos_designs

Proposed changes

Divide the existing default platform setting list item into two, creating a new one for the 750 (and 755 and 758).
This new list item has the management interface set to Management0, with all other attributes copied.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@matthewgottlieb matthewgottlieb changed the title fix management interface for 750 platforms Fix management interface for 750 platforms Jan 28, 2024
@matthewgottlieb matthewgottlieb changed the title Fix management interface for 750 platforms Fix: management interface for 750 platforms Jan 28, 2024
@gmuloc gmuloc changed the title Fix: management interface for 750 platforms Fix(eos_designs): management interface for 750 platforms Jan 29, 2024
@ClausHolbechArista
Copy link
Contributor

I believe these default platform_settings are hardcoded in the docs somewhere. Please update accordingly (and correct if you find other differences). Thanks!

@matthewgottlieb matthewgottlieb marked this pull request as ready for review January 30, 2024 02:19
@matthewgottlieb matthewgottlieb requested review from a team as code owners January 30, 2024 02:19
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added type: dependencies Pull requests that update a dependency file and removed state: conflict PR with conflict labels Jan 31, 2024
@ClausHolbechArista
Copy link
Contributor

Moving to draft until rebasing is done. Seems like something went wrong in the merge/rebase regarding symlinks. The requirements files are symlinked a few places and here the links are being replaced with regular files.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft January 31, 2024 06:46
@ClausHolbechArista ClausHolbechArista force-pushed the fix-platform-750 branch 2 times, most recently from 915a6d1 to 71fe417 Compare January 31, 2024 07:04
@github-actions github-actions bot removed the type: dependencies Pull requests that update a dependency file label Jan 31, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review January 31, 2024 07:05
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 31, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team January 31, 2024 07:08
carlbuchmann
carlbuchmann previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann dismissed their stale review February 1, 2024 03:01

made some changes!

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc
gmuloc approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@gmuloc gmuloc merged commit 1725036 into aristanetworks:devel Feb 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann left review comments

Assignees

@matthewgottlieb matthewgottlieb

Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect management interface for 750 platform
4 participants
@matthewgottlieb @ClausHolbechArista @gmuloc @carlbuchmann